Bill items could not autocomplete if item has 0 quantity.

Ritche Ramos ( User )

Commented 5 years ago

Found this on the ajax for populating the bill items.

select `id` as `item_id`, `name`, `sku`, `sale_price`, `purchase_price`, `tax_id` from `ch1_items` where `quantity` > '0' and (`name` LIKE '%7-up%' or `sku` LIKE '%7-up%') and `ch1_items`.`deleted_at` is null and `ch1_items`.`company_id` = '1'

Shouldn't `quantity` > '0' be `enabled` = '1' ?

Found this on the ajax for populating the bill items. 
<code class="phpdebugbar-widgets-sql">select `id` as `item_id`, `name`, `sku`, `sale_price`, `purchase_price`, `tax_id` from `ch1_items` where `quantity` > '0' and (`name` LIKE '%7-up%' or `sku` LIKE '%7-up%') and `ch1_items`.`deleted_at` is null and `ch1_items`.`company_id` = '1'</code> 
  
<code class="phpdebugbar-widgets-sql">Shouldn't </code><code class="phpdebugbar-widgets-sql"><code class="phpdebugbar-widgets-sql">`quantity` > '0' be </code></code><code class="phpdebugbar-widgets-sql"><code class="phpdebugbar-widgets-sql"><code class="phpdebugbar-widgets-sql"><code class="phpdebugbar-widgets-sql">`enabled` = '1' ? </code></code></code></code>

Ritche Ramos ( User )

Commented 5 years ago

Where can I change this?

Denis Dulici ( Admin )

Commented 5 years ago

Ritche, you can change it from the following line:

https://github.com/akaunting/akaunting/blob/master/app/Models/Item/Item.php#L92

Will fix in the next version.

Ritche Ramos ( User )

Commented 5 years ago

Thanks for the direction!

Ritche Ramos ( User )

Commented 5 years ago

By looking at the code its looks like the invoice module could use this too. Which makes the previous code exactly true for the previous code. is there a way we can put an if statement indicating if the function caller was invoice or bill?

Bryan Nazar ( User )

Commented 5 years ago

I also had this issue.

Forum

All Discussions

Ritche Ramos ( User )

Ritche Ramos ( User )

Denis Dulici ( Admin )

Ritche Ramos ( User )

Ritche Ramos ( User )

Bryan Nazar ( User )