Updating on Windows fails if path to PHP.exe contains spaces

Posted in CategoryInstallation & Update
  • Rct    ( User ) 4 days ago
    So, I tried updating 2.x for the first time recently and noticed that the last step fails because the path to PHP.exe has a space in it on my server. The program isn't putting quotes around the binary path, which is required on Windows when paths contain spaces.

    I have PHP installed in C:\Program Files\PHP\v7.3, and when you run an update in the web interface, it gets to 80%, then fails with the (rather well known to Windows CMD users): 'c:\program' is not recognized as an internal or external command, operable program or batch file.

    The command it's trying to run is the update:finish command, which I had to manually run from a command prompt with proper quoting to finish my update.

    Can this bug be fixed so the updater supports PHP being installed in paths with spaces?
  • Denis Duliçi    ( Admin ) 4 days ago

    Feel free to make this change:

  • Rct    ( User ) 4 days ago
    Thanks! I made the changes in that file, hopefully updates will be smooth next time.

Please login or register to leave a response.